test(e2e): add stovepipe end-to-end suite driving the ingest→process pipeline#301
Merged
Conversation
…pipeline Summary: Intent: - Stovepipe had a full-stack integration suite but no e2e suite, and nothing proved the asynchronous process stage actually drained a message — the integration suite only asserts that Ingest publishes one. - Add an e2e suite whose distinguishing charter is proving the ingest→process pipeline runs end-to-end, mirroring the submitqueue test/e2e pattern. Changes: - Add test/e2e/stovepipe with a testify suite (suite_test.go) that boots service/stovepipe/docker-compose.yml under the e2e-stovepipe context and a harness (harness_test.go) of intent-level helpers. - Tests cover Ping, Ingest happy-path (synchronous request/request_uri/queue_messages side effects plus asynchronous consumption), and Ingest idempotency/dedup. - awaitProcessed observes the durable acked-offset watermark in queue_offsets (which only advances on ack) rather than the message's delivery-state row, because the queue GCs acked messages from queue_messages once the watermark passes them. - Left the existing integration suite untouched (added alongside, per the submitqueue precedent of keeping both levels). Test Plan: - bazel test //test/e2e/stovepipe:stovepipe_test passes (Ping, Ingest happy-path, Ingest idempotency) against the Docker Compose stack. Non-vacuity confirmed: an offset-based signal that is absent makes awaitProcessed time out (observed while iterating), so the async assertion is real. --- <sub>Generated by the 🪄 [pr-create](https://sg.uberinternal.com/code.uber.internal/uber-code/devexp-agent-marketplace/-/blob/claude-code/plugins/dev/uber-dev/skills/pr-create/SKILL.md) skill in devexp-agent-marketplace</sub>
mnoah1
approved these changes
Jul 7, 2026
mnoah1
left a comment
mnoah1
left a comment
Contributor
There was a problem hiding this comment.
Approved pending the fix to the build failure
behinddwalls
force-pushed
the
preetam/stovepipe-e2e
branch
from
896d03b to
4e7b369
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Test Plan
Generated by the 🪄 pr-create skill in devexp-agent-marketplace
Issues